Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor event_sample_rate to analytics #705

Merged
merged 6 commits into from
Mar 4, 2019
Merged

Refactor event_sample_rate to analytics #705

merged 6 commits into from
Mar 4, 2019

Conversation

delner
Copy link
Contributor

@delner delner commented Mar 1, 2019 •
edited
Loading

This pull request:

  • Renames Datadog::Contrib::Sampling to Datadog::Contrib::Analytics
  • Changes event_sample_rate for current integrations to analytics_sample_rate and analytics_enabled. (Breaking change)
  • Adds environment variables for each of these configuration options.

It does not implement the global setting, which will be done in another pull request.

Serves a prerequisite for #697.

@delner delner added integrations Involves tracing integrations breaking-change Involves a breaking change dev/refactor Involves refactoring existing components labels Mar 1, 2019
@delner delner added this to the 0.20.0 milestone Mar 1, 2019
@delner delner self-assigned this Mar 1, 2019
@delner delner requested a review from brettlangdon March 1, 2019 21:59
@delner delner force-pushed the refactor/event_sample_rate_to_analytics branch from a3b1d36 to db23400 Compare March 2, 2019 00:00
@delner delner force-pushed the refactor/event_sample_rate_to_analytics branch 2 times, most recently from e11fb7d to b17fe86 Compare March 4, 2019 16:37
brettlangdon
brettlangdon approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, pretty straight forward

docs/GettingStarted.md Outdated Show resolved Hide resolved
spec/ddtrace/contrib/analytics_spec.rb Outdated Show resolved Hide resolved
@delner delner force-pushed the refactor/event_sample_rate_to_analytics branch from b17fe86 to f611625 Compare March 4, 2019 20:11
@delner delner force-pushed the refactor/event_sample_rate_to_analytics branch from 0713dd4 to dd19450 Compare March 4, 2019 20:17
@delner delner merged commit ca87476 into 0.20-dev Mar 4, 2019
@delner delner deleted the refactor/event_sample_rate_to_analytics branch March 4, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees

@delner delner

Labels
breaking-change Involves a breaking change dev/refactor Involves refactoring existing components integrations Involves tracing integrations
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@delner @brettlangdon