Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HTTP to use instrumentation module #703

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

delner
Copy link
Contributor

@delner delner commented Feb 27, 2019

The HTTP integration is using a class_eval to rewrite methods which can cause conflicts. This pull request converts the instrumentation into a module that is prepended instead.

@delner delner added integrations Involves tracing integrations dev/refactor Involves refactoring existing components labels Feb 27, 2019
@delner delner added this to the 0.20.0 milestone Feb 27, 2019
@delner delner self-assigned this Feb 27, 2019
@delner delner merged commit 2708f16 into 0.20-dev Feb 28, 2019
@delner delner deleted the refactor/http_instrumentation_module branch February 28, 2019 14:48
This was referenced Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/refactor Involves refactoring existing components integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants