Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable distributed tracing by default #701

Merged
merged 12 commits into from
Feb 28, 2019
Merged

Enable distributed tracing by default #701

merged 12 commits into from
Feb 28, 2019

Conversation

brettlangdon
Copy link
Member

This PR updates all integrations which allow enabling distributed tracing to have it enabled by default.

delner
delner reviewed Feb 27, 2019
View reviewed changes
Copy link
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from what I can see; I think one small line needs to be removed, but otherwise should be good to merge. Thanks!

delner
delner previously approved these changes Feb 27, 2019
View reviewed changes
@brettlangdon brettlangdon changed the base branch from master to 0.20-dev February 28, 2019 14:54
@brettlangdon brettlangdon merged commit 3d1706b into 0.20-dev Feb 28, 2019
@brettlangdon brettlangdon deleted the brettlangdon/distributed.tracing.enabled branch February 28, 2019 17:50
@brettlangdon brettlangdon added this to the 0.20.0 milestone Mar 7, 2019
This was referenced Mar 7, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delner delner delner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@brettlangdon @delner