Add Datadog::DeprecatedPin for phasing out Datadog::Pin usage #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
core
brettlangdon
approved these changes
Feb 19, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to refactor some older integrations from Pin-based configuration to configuration objects, we need to deprecate the use of Pins in specific integrations as they migrate away.
This pull request introduces a
Datadog::DeprecatedPinwhich can be mixed into an existingDatadog::Pin, to append warnings when it's accessed. Typically, integrations that use pins will mix in this module to add deprecation warnings, then override any behavior on their copy of the Pin to update their configuration where appropriate.By implementing this, we can ease the transition to new configuration by notifying users of the change in behavior, while providing backwards compatibility for older configurations.