Collect runtime metrics from Ruby environment #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
core
delner
force-pushed
the
feature/runtime_metric_collection
branch
2 times, most recently
from
5469aea
to
be6e3fd
Compare
5 tasks
delner
force-pushed
the
feature/runtime_metric_collection
branch
4 times, most recently
from
00725c6
to
d56b496
Compare
delner
force-pushed
the
feature/runtime_metric_collection
branch
2 times, most recently
from
10f1961
to
16dac13
Compare
delner
force-pushed
the
feature/runtime_metric_collection
branch
from
16dac13
to
5cf1d4a
Compare
delner
commented
Mar 21, 2019
delner
force-pushed
the
feature/runtime_metric_collection
branch
from
5cf1d4a
to
dcd79f9
Compare
pawelchcki
previously requested changes
Apr 9, 2019
There was a problem hiding this comment.
Great Job @delner! Looks like really awesome addition!
Left one suggestion about using counters to correctly process some metrics. Otherwise looks good!
delner
force-pushed
the
feature/runtime_metric_collection
branch
from
ecea8e1
to
1b53343
Compare
brettlangdon
dismissed
pawelchcki’s stale review
We are deferring requested changes since it doesn't really effect Ruby metrics at this time.
pawelchcki
approved these changes
Apr 10, 2019
delner
force-pushed
the
feature/runtime_metric_collection
branch
from
1b53343
to
a30d84f
Compare
brettlangdon
approved these changes
Apr 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to improve insight into application performance, we'd like to collect metrics that describe the Ruby environment, so that this data can be displayed with traces in the Datadog trace page.
This pull request adds two major new parts to the tracer:
Datadog::Metricswhich is an application level Statsd instance which can be used to send metrics. If Statsd is available, it will autoconfigure its client to send stats to the agent on UDP port8125.Datadog::Runtimenamespace which contains functions for collecting stats from the runtime environment. This is used in theAsyncWorkerthread to collect and broadcast runtime metrics to the client configured withinDatadog::Metrics.TODO:
runtime-idtagservicetag