Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mongo NoMethodError when thread variable not set #675

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Fix Mongo NoMethodError when thread variable not set #675

merged 1 commit into from
Jan 17, 2019

Conversation

delner
Copy link
Contributor

@delner delner commented Jan 17, 2019

Per #674, this pull request adds some additional safety around get/set/delete operations in the Mongo integration. Prior to this, if completed or failed events were sent before started, a NoMethodError for nil would be raised.

@delner delner self-assigned this Jan 17, 2019
@delner delner added bug Involves a bug integrations Involves tracing integrations community Was opened by a community member labels Jan 17, 2019
@delner delner mentioned this pull request Jan 17, 2019
Closed
@delner delner added this to the 0.18.3 milestone Jan 17, 2019
@delner delner merged commit 3686915 into master Jan 17, 2019
@delner delner deleted the fix/mongo_nomethoderror_for_missing_thread_var branch January 17, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

@pawelchcki pawelchcki Awaiting requested review from pawelchcki

Assignees

@delner delner

Labels
bug Involves a bug community Was opened by a community member integrations Involves tracing integrations
Projects
None yet
Milestone
0.18.3
Development

Successfully merging this pull request may close these issues.
2 participants
@delner @brettlangdon