Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event_sample_rate to integrations #666

Merged
merged 13 commits into from
Jan 3, 2019
Merged

Add event_sample_rate to integrations #666

merged 13 commits into from
Jan 3, 2019

Conversation

delner
Copy link
Contributor

@delner delner commented Dec 28, 2018 •
edited
Loading

Using the feature defined in #665, this pull request adds the event sample rate tag, if configured, to the following integrations:

  • delayed_job
  • racecar
  • rack
  • rake
  • resque
  • shoryuken
  • sidekiq
  • sucker_punch

@delner delner added core Involves Datadog core libraries integrations Involves tracing integrations do-not-merge/WIP Not ready for merge feature Involves a product feature labels Dec 28, 2018
@delner delner added this to the 0.19.0 milestone Dec 28, 2018
@delner delner self-assigned this Dec 28, 2018
@delner delner force-pushed the feature/add_event_sample_rate_to_integrations branch from 8aae345 to 1f6651c Compare December 28, 2018 17:20
@delner
Copy link
Contributor Author

delner commented Dec 28, 2018

@pawelchcki do you think this Datadog::Contrib::Sampling module is idiomatic? Or is there a cleaner/nicer/prettier way of adding this? Not sure I love the current approach but its pretty simple and easy to work with. Suggestions welcome.

@brettlangdon
Copy link
Member

Not sure I can comment on whether that new module is idiomatic, but this approach seems good/pretty straight forward to me.

@delner delner force-pushed the feature/add_event_sample_rate_to_integrations branch from 58302b1 to 0bea126 Compare January 2, 2019 17:59
@delner delner removed the do-not-merge/WIP Not ready for merge label Jan 2, 2019
@delner delner force-pushed the feature/add_event_sample_rate_to_integrations branch from d42b492 to f520e88 Compare January 3, 2019 19:17
@delner
Copy link
Contributor Author

delner commented Jan 3, 2019

@brettlangdon Changes made, ready for another review.

@delner delner merged commit 3ae075d into 0.19-dev Jan 3, 2019
@delner delner deleted the feature/add_event_sample_rate_to_integrations branch January 3, 2019 19:31
@delner delner mentioned this pull request Feb 22, 2019
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

@pawelchcki pawelchcki Awaiting requested review from pawelchcki

Assignees

@delner delner

Labels
core Involves Datadog core libraries feature Involves a product feature integrations Involves tracing integrations
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@delner @brettlangdon