Skip to content

changelog/check: stop flagging base-branch CHANGELOG.md edits as PR changes #6451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
p-datadog wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −4
Open

changelog/check: stop flagging base-branch CHANGELOG.md edits as PR changes #6451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9703e8e
changelog/check: stop flagging base-branch CHANGELOG.md edits as PR c…
p-ddsign Oct 8, 2026
4365104
changelog/check: remove diff rationale comment
p-ddsign Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/scripts/check_changelog_release_only.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,17 @@ if [[ -z "${HEAD_REF:-}" ]]; then
exit 1
fi

if [[ -z "${BASE_SHA:-}" ]]; then
echo "Error: BASE_SHA environment variable is not set"
if [[ -z "${BASE_REF:-}" ]]; then
echo "Error: BASE_REF environment variable is not set"
exit 1
fi

changed_files=$(git diff --no-renames --name-only "${BASE_SHA}"...HEAD)
if [[ -z "${PR_HEAD_SHA:-}" ]]; then
echo "Error: PR_HEAD_SHA environment variable is not set"
exit 1
fi

changed_files=$(git diff --no-renames --name-only "origin/${BASE_REF}...${PR_HEAD_SHA}")

touches_changelog=false
if grep -qx 'CHANGELOG.md' <<< "${changed_files}"; then
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,8 @@ jobs:
if: github.event_name == 'pull_request'
env:
HEAD_REF: ${{ github.head_ref }}
BASE_SHA: ${{ github.event.pull_request.base.sha }}
BASE_REF: ${{ github.event.pull_request.base.ref }}
PR_HEAD_SHA: ${{ github.event.pull_request.head.sha }}
run: .github/scripts/check_changelog_release_only.sh

- name: Validate changelog fragment schema
Expand Down
Loading