Repository navigation
Remove profiling clock failure setting and handling - #6449
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 783cc1fd52
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
783cc1f to
03646c5
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: aeecbf2 | Docs | View more details | Give us feedback! |
BenchmarksBenchmark execution time: 2026-10-09 12:01:01 Comparing candidate commit aeecbf2 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 0 unstable metrics.
|
There was a problem hiding this comment.
👍 LGTM Looks amazing, thanks for digging on this one!
It was so annoying to go all the time "uuuhhh time can fail here, how can we handle it, we're kinda in the middle of something".
I had AI friend do a "just in case" pass on linux/glibc/musl sources and it confirmed our expectations -- other than 32-bit or weird configurations (seccomp blocking time syscall) we're good!
These helpers read fixed system clocks supported on the target platforms: CLOCK_REALTIME, CLOCK_MONOTONIC and CLOCK_MONOTONIC_COARSE on Linux, and CLOCK_MONOTONIC_RAW and CLOCK_MONOTONIC_RAW_APPROX on macOS. They always pass a valid stack-allocated timespec to clock_gettime(), so invalid clock IDs and invalid output pointers cannot occur here. Unlike per-thread CPU clocks, these clocks cannot disappear when a thread exits, making failure handling unnecessary for these helpers. Remove raise_on_failure_setting and its arguments from all callers, along with the zero-result checks and deferred ClockFailure exception machinery. Keep per-thread CPU clock error handling unchanged. Co-authored-by: Ivo Anjo <ivo@ivoanjo.me> Co-authored-by: Codex (GPT-6.1-Sol) <noreply@openai.com>
75c23b6 to
aeecbf2
Compare
These helpers read fixed system clocks supported on the target platforms: CLOCK_REALTIME, CLOCK_MONOTONIC and CLOCK_MONOTONIC_COARSE on Linux, and CLOCK_MONOTONIC_RAW and CLOCK_MONOTONIC_RAW_APPROX on macOS. They always pass a valid stack-allocated timespec to clock_gettime(), so invalid clock IDs and invalid output pointers cannot occur here. Unlike per-thread CPU clocks, these clocks cannot disappear when a thread exits, making failure handling unnecessary for these helpers.
Remove raise_on_failure_setting and its arguments from all callers, along with the zero-result checks and deferred ClockFailure exception machinery. Keep per-thread CPU clock error handling unchanged.
What does this PR do?
Motivation:
Simplicity, keeping it simple, clean.
Change log entry
Additional Notes:
How to test the change?