Repository navigation
Conversation
Matrix generation now prefers the timings published at TonyCTHsu/dd-test-weights and falls back to the checked-in ci_task_timings.json when the fetch fails.
Weights now live only in the dd-test-weights repository; matrix generation fetches them at run time. When the fetch fails, tasks fall back to the default duration estimate instead of a local file.
TonyCTHsu
added
the
AI Generated
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 3 Pipeline jobs failed
ℹ️ InfoNo other issues found (see more)🧪 All tests passed 🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 2270955 | Docs | View more details | Give us feedback! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fetches unit-test timing weights at matrix-generation time from TonyCTHsu/dd-test-weights instead of the checked-in
tasks/ci_task_timings.json, and deletes that 13k-line file. On fetch failure, tasks use the default duration estimate: deterministic matrix, green jobs, degraded balance only.Carries the commits of #6429 and #6439; merge after those or rebase on them.
Motivation:
The manifest pollutes every diff and needs a manual refresh. In a dedicated repo, a daily workflow aggregates the
timings-*artifacts thatUnit Testsalready uploads and commits new weights itself. New tasks get real weights on the first refresh after landing; deleted tasks drop out because the manifest is rebuilt from scratch. The single GET of the weights file is also the seam where a CI Visibility distribution API can later replace the file store.Change log entry
Not needed: internal CI scheduling only.
Additional Notes:
WEIGHTS_URLpoints at a personal repo used to validate the design; move it to a tracer-team repo before merge. Validated end to end on run 37773758476 (workflow_dispatch): all 30 jobs passed, shards estimated at 441.7–446.9s, no fallback warnings.How to test the change?
bundle exec rspec spec/tasks/github_batching_spec.rb(7 examples, includes fetch-failure path) andrake github:generate_batchesfor a live matrix. On this PR'sUnit Testsrun: job summary shows per-batch estimated seconds; logs contain no "Falling back" warning.