Repository navigation
Conversation
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 76d6f6c | Docs | View more details | Give us feedback! |
dubloom
force-pushed
the
dubloom/supported-versions
branch
from
October 7, 2026 15:27
2b33ae0 to
a955778
Compare
dubloom
force-pushed
the
dubloom/supported-versions
branch
from
October 7, 2026 15:31
a955778 to
8f194ee
Compare
dubloom
marked this pull request as ready for review
October 8, 2026 11:01
dubloom
requested review from
mabdinur and
marcotc
and removed request for
a team
October 8, 2026 11:01
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
y9v
reviewed
Oct 8, 2026
| include Contrib::Integration | ||
|
|
||
| MINIMUM_VERSION = Contrib::Rails::Ext::MINIMUM_VERSION | ||
| MAKARA_MINIMUM_VERSION = Gem::Version.new("0.3.5") |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes file giving information about instrumentation version support and replace it by a script that uploads the file to a S3 bucket. The script is generating a file that looks like: https://github.com/DataDog/dd-trace-rb/blob/fba732e94c43c3c8c1d08cb49befa80bd3026f89/supported_versions.json.
Motivation:
We are standardizing the information about version support across repository following this RFC. It will allow to consume all that data in that central place. You can see how it will look like there: https://apm-integrations-portal.us1.prod.dog/versions-support?tracer_id=dd-trace-rb&integration_id=dd-trace-rb-action_cable&tracer_version=master.
Additional Notes:
AI is the main author of my commit. I looked at the overall architecture of the changes which makes sense and tested it, the output looks right. As I'm not very familiar with ruby, I asked @marcotc to take a look (and he did and push some commits).
How to test the change?
The CI has been tested and is working here: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-rb/-/jobs/2120854052
Follow Up
Right now, it is hard to deal with exceptions (such as graphql) in version supported because of the way we declare the supported versions in the integrations so we can only deal with minimum and maximum. I think it would be good to make a new system to declare version supported which is consistent across integrations and can deal with exceptions.