fixes #630 potential performance hit logging cache key #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* using ActiveSupport::Cache.expand_cache_key which is also used by Rails to expand the cache key without enumerating relations
|
@delner I looked into this, and this seems like the most straightforward way to work around it, since it's anyway used inside Rails. I was trying to write a test for it, but somehow couldn't get tests running using docker-compose. I'm not sure exactly why. I had all containers running, and then using bash inside the tracer container I ran |
|
On a side note, it seems to me like the ddtracer patches ActiveSupport in order to trace cache reads, writes, etc. But wouldn't be more elegant to use the built-in rails instrumentation for that? https://edgeguides.rubyonrails.org/active_support_instrumentation.html#active-support |
|
@gingerlime On the tests, you almost had it right with |
delner
added
bug
gingerlime
force-pushed
the
630-cache-key-performance-fix
branch
from
cd65753
to
280af3d
Compare
|
@delner I added a couple of simple tests, and CI looks green (apart from what looks like an unrelated failure). Regardless, I'm curious to hear your thoughts about #635 (comment) ... |
|
@gingerlime Honest answer as to why we don't use the ActiveSupport hooks: I don't know. It might be because we support Rails versions as old as 3.0 and this doesn't exist in those older versions, or that we simply didn't see that event when the integration was created. If a PR was created to use that instrumentation hook, and it was implemented in a way such that it passes our test suite, I would seriously consider merging it. I don't know if we'd get around to writing such a refactor soon otherwise; we'd likely add it to the backlog instead. |
delner
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used by Rails to expand the cache key without enumerating
relations