[rails] avoid conditional require for active_record contrib module #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palazzem
force-pushed
the
palazzem/rails-without-ar
branch
from
88a4d53
to
623b14f
Compare
LotharSee
approved these changes
Jan 19, 2017
palazzem
force-pushed
the
palazzem/rails-without-ar
branch
from
623b14f
to
2e8dc0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Related to: #40
Avoids conditional require for
ddtrace/contrib/rails/active_recordmodule. In some configuration (and/or for order import), it's possible that the constantDatadog::Contrib::Rails::ActiveRecordis not initialized:The loading / auto instrumentation behavior is not changed and everything behaves like before.