Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make integration configurations more consistent #576

Conversation

delner
Copy link
Contributor

@delner delner commented Oct 1, 2018

For the changes made in #544, we want to make configuration consistent across the integrations that were already converted to the new configuration API defined in #450.

This includes:

  • ActiveRecord
  • ConcurrentRuby
  • RestClient
  • Sequel

We should merge this to #544 so all changes can be deployed together.

@delner delner added integrations Involves tracing integrations dev/refactor Involves refactoring existing components labels Oct 1, 2018
@delner delner self-assigned this Oct 1, 2018
@delner delner requested a review from pawelchcki October 1, 2018 15:14
Copy link
Contributor

@pawelchcki pawelchcki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@delner delner merged commit d386618 into refactor/upgrade_to_integration_configuration Oct 1, 2018
@delner delner deleted the refactor/make_integration_configurations_consistent branch October 1, 2018 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/refactor Involves refactoring existing components integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants