Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ActiveModelSerializers integration configuration #568

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Implement ActiveModelSerializers integration configuration #568

merged 1 commit into from
Oct 1, 2018

Conversation

delner
Copy link
Contributor

@delner delner commented Sep 26, 2018

This pull request implements the configuration core from #450 in the ActiveModelSerializers integration.

@delner delner added integrations Involves tracing integrations dev/refactor Involves refactoring existing components labels Sep 26, 2018
@delner delner self-assigned this Sep 26, 2018
@delner delner changed the title Refactored: ActiveModelSerializers to use Datadog::Contrib::Integration. Implement gRPC integration configuration Sep 26, 2018
@delner delner changed the title Implement gRPC integration configuration Implement ActiveModelSerializers integration configuration Sep 26, 2018
@delner delner mentioned this pull request Sep 26, 2018
Merged
26 tasks
@delner delner force-pushed the refactor/active_model_serializers_integration_configuration branch from 028d1e9 to f4672d8 Compare September 26, 2018 21:20
@delner delner force-pushed the refactor/active_model_serializers_integration_configuration branch from f4672d8 to 8b56e48 Compare September 26, 2018 21:21
pawelchcki
pawelchcki approved these changes Oct 1, 2018
View reviewed changes
Copy link
Contributor

@pawelchcki pawelchcki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@delner delner merged commit 09988b3 into refactor/upgrade_to_integration_configuration Oct 1, 2018
@delner delner deleted the refactor/active_model_serializers_integration_configuration branch October 1, 2018 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelchcki pawelchcki pawelchcki approved these changes

Assignees

@delner delner

Labels
dev/refactor Involves refactoring existing components integrations Involves tracing integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delner @pawelchcki