use direct method replacement for the redis patcher #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ufoot
reviewed
Jan 13, 2017
| end | ||
| end | ||
|
|
||
| @patched = true |
There was a problem hiding this comment.
I'd rather leave the @patched = true section in the caller, as patch_redis_client is only part of the global patching process, and calling it alone won't patch properly.
There was a problem hiding this comment.
That wasn't intended, thank you for pointing it out :)
galdor
force-pushed
the
nicolas/infinite-recursion
branch
2 times, most recently
from
43d216a
to
31662e1
Compare
Adding ancestors to the redis client class will sometimes lead to infinite recursion if call/call_pipeline have been monkey patched by external code.
galdor
force-pushed
the
nicolas/infinite-recursion
branch
from
31662e1
to
c30be5e
Compare
LotharSee
approved these changes
Jan 16, 2017
ufoot
approved these changes
Jan 17, 2017
| def call(*args, &block) | ||
| @datadog_test_called ||= false | ||
| if @datadog_test_called | ||
| raise Minitest::Assertion, 'patched methods called in infinite loop' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ancestors to the redis client class will sometimes lead to
infinite recursion if call/call_pipeline have been monkey patched by
external code.