Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Mysql2 integration configuration #559

Merged
merged 2 commits into from
Sep 26, 2018
Merged

Implement Mysql2 integration configuration #559

merged 2 commits into from
Sep 26, 2018

Conversation

delner
Copy link
Contributor

@delner delner commented Sep 24, 2018

This pull request implements the configuration core from #450 in the Mysql2 integration.

@delner delner added integrations Involves tracing integrations dev/refactor Involves refactoring existing components labels Sep 24, 2018
@delner delner self-assigned this Sep 24, 2018
@delner delner mentioned this pull request Sep 24, 2018
Merged
26 tasks
pawelchcki
pawelchcki approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@pawelchcki pawelchcki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Th high Boilerplate to Logic ratio is especially visible in this PR - but its not the scope here. Otherwise it LGTM

@delner delner merged commit 4a5e313 into refactor/upgrade_to_integration_configuration Sep 26, 2018
@delner delner deleted the refactor/mysql2_integration_configuration branch September 26, 2018 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelchcki pawelchcki pawelchcki approved these changes

Assignees

@delner delner

Labels
dev/refactor Involves refactoring existing components integrations Involves tracing integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delner @pawelchcki