Use incoming sample priority to decide if the span should be sampled or not #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelchcki
force-pushed
the
fix/distributed_sampling
branch
from
0b78562
to
13c3509
Compare
pawelchcki
changed the title
pawelchcki
force-pushed
the
fix/distributed_sampling
branch
from
4c05cdd
to
0a74c05
Compare
delner
previously approved these changes
Aug 23, 2018
test/sampler_test.rb
Outdated
| tracer.provider.context.sampling_priority = Datadog::Ext::Priority::USER_REJECT | ||
| tracer.trace('test_reject', trace_id: 4) {} | ||
|
|
||
| assert_equal(2, tracer.writer.spans.length) |
There was a problem hiding this comment.
For brevity, this is okay right now, but when this gets refactored into RSpec, we should assert each one did as expected. Otherwise this test could pass if it were doing the complete opposite that we want, because there would still be two spans.
There was a problem hiding this comment.
Yeah. I've just added a test te verify all spans are named 'test_keep'.
Also this would have probably been nicer to write in RSpec. I chose to keep minitest only to shorten the dev-time.
|
Thanks for reviewing! @delner I've added a test to verify only the spans we want are kept. Can you rereview ? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If sampling_priority was set on context from incoming headers or manually by the user. That value then got ignored and overwritten by
PrioritySampler.This PR fixes this issue.
TODO: