Prevent HttpPropagator errors given a nil Context #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
force-pushed
the
bugfix/prevent_http_propagation_nil_context
branch
from
01c1556
to
370ece8
Compare
palazzem
previously approved these changes
Jul 30, 2018
delner
force-pushed
the
bugfix/prevent_http_propagation_nil_context
branch
from
370ece8
to
1dce53a
Compare
|
Added a test case for when a context exceeds its max size, causing this error. It verifies the safeguard works against that. |
palazzem
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you provide
HttpPropagator#inject!a nilContext, it will raise an error. This pull request adds a simple check to avoid errors if traces can't be propagated for this reason.Depends on #501 which refactors some tests.