Add JRuby 10.0 support #4928
Open
Add JRuby 10.0 support #4928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahchen6
force-pushed
the
sarahchen6/add-jruby-10.0
branch
from
1ff5503 to
8f670ba
Compare
BenchmarksBenchmark execution time: 2025-10-09 21:53:01 Comparing candidate commit 765d7e9 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics. scenario:profiling - Allocations ()
|
sarahchen6
force-pushed
the
sarahchen6/add-jruby-10.0
branch
from
27ec659 to
4438796
Compare
lloeki
reviewed
Oct 3, 2025
sarahchen6
force-pushed
the
sarahchen6/add-jruby-10.0
branch
2 times, most recently
from
23bcef4 to
da1db77
Compare
marcotc
reviewed
Oct 3, 2025
sarahchen6
force-pushed
the
sarahchen6/add-jruby-10.0
branch
3 times, most recently
from
11cbb99 to
bf88571
Compare
sarahchen6
force-pushed
the
sarahchen6/add-jruby-10.0
branch
2 times, most recently
from
bf88571 to
cacdda7
Compare
Typing analysisIgnored filesThere are 539 ignored files in the Steepfile out of 836. Ignored filesNote: Ignored files are excluded from the next sections.
|
marcotc
approved these changes
Oct 8, 2025
sarahchen6
force-pushed
the
sarahchen6/add-jruby-10.0
branch
2 times, most recently
from
3e675aa to
37e62ed
Compare
sarahchen6
force-pushed
the
sarahchen6/add-jruby-10.0
branch
from
37e62ed to
765d7e9
Compare
sarahchen6
commented
Oct 9, 2025
| # MongoDB does not support JRuby 10.0, which fails on an error related the bson_ruby NativeService for latest versions. | ||
| # https://github.com/mongodb/mongo-ruby-driver#mongodb-ruby-driver | ||
| 'mongo-latest' => '✅ 2.5 / ✅ 2.6 / ✅ 2.7 / ✅ 3.0 / ✅ 3.1 / ✅ 3.2 / ✅ 3.3 / ✅ 3.4 / ✅ 3.5 / ✅ jruby / ❌ jruby 10.0', | ||
| 'mongo-min' => '✅ 2.5 / ✅ 2.6 / ✅ 2.7 / ✅ 3.0 / ✅ 3.1 / ✅ 3.2 / ✅ 3.3 / ✅ 3.4 / ✅ 3.5 / ✅ jruby / ❌ jruby 10.0', |
There was a problem hiding this comment.
I'm stuck on how to properly skip JRuby 10.0 for mongodb tests (see also the tasks/runtime_matcher.rb file), or if that's even the right way to go. JRuby 10.0 fails with the latest version 2.21.3 with an error related to:
Failure/Error: Unable to find org.bson_ruby.NativeService.basicLoad(NativeService.java to read failed line
Java::JavaLang::NoSuchMethodError:
'org.jruby.RubyModule org.jruby.Ruby.fastGetModule(java.lang.String)'...
Given the lack of support, I propose to skip these tests, but I'm not sure how best to skip them. What am I missing?
There was a problem hiding this comment.
This sounds like a bug in the jruby version of the bson gem; did you spot which version we're using?
(We could adjust the dsl to support skipping jruby versions, but it may be easier to skip on all jruby versions temporarily rather than doing that...?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds JRuby 10.0 support to CI.
Motivation:
JRuby 10.0 is out!
Change log entry
No change log entry.
Additional Notes:
Tests that are skipped and need further investigation:
Datadog::Core::Remote::Component::BarrierDatadog::Tracing::Contrib::Shoryuken::TracerThese all lead with
TODO: JRuby 10.0 -...I also added a temporary
jruby_100?method as recommended by Marco that includes a comment to update Compatibility documentation after all tests are addressed.The skipped tests are documented on the Ruby Guild board: https://github.com/orgs/DataDog/projects/47/views/10?query=sort%3Aupdated-desc+is%3Aopen&sliceBy%5Bvalue%5D=lang+support
How to test the change?
Green CI.