[NO-TICKET] RFC: Bindings for libdatadog ddsketch API #4858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericfirth
approved these changes
Aug 20, 2025
On a second pass, this does seem like it makes sense to live inside core.
We were introducing a bit too much copy/pasta for each part of core that depends on libdatadog_api, so I've consolidated them. This opens the door to easily adding ddsketch without more repetition.
We'll use this for integration-style testing with the libdatadog ddsketch implementation. This file was imported from https://raw.githubusercontent.com/DataDog/sketches-go/cd8144afd502b4ee58d5f6c2efe49c4bcf56270b/ddsketch/pb/ddsketch.proto without any changes.
This depends on the fixes in DataDog/libdatadog#1185 .
ericfirth
force-pushed
the
ivoanjo/libdatadog-ddsketch
branch
from
f28a5ca to
752169a
Compare
Typing analysisIgnored filesThere are 539 ignored files in the Steepfile out of 841. Ignored filesNote: Ignored files are excluded from the next sections.
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 8ae9432 | Docs | Was this helpful? Give us feedback! |
BenchmarksBenchmark execution time: 2025-10-10 15:52:25 Comparing candidate commit 8ae9432 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics. scenario:tracing - Propagation - Datadog
|
|
This is ready for review! Let's get this show on the road :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a
Datadog::Core::DDSketchAPI that is implemented by libdatadog via the recently added ddsketch ffi ( DataDog/libdatadog#1135 ).For more details on ddsketch, see https://www.datadoghq.com/blog/engineering/computing-accurate-percentiles-with-ddsketch/ .
I'm opening this PR as an RFC/draft for two reasons:
Motivation:
Some upcoming APM features are going to require ddsketch support on the library (the agent has been using it for a long time).
Change log entry
None.
Additional Notes:
N/A
How to test the change?
You'll need libdatadog master to run this branch. Other than that, I've included test coverage for this API, including a encode/decode round trip.