Fix variable names in rescue blocks#481
Conversation
|
Hey @kitop, thanks for the PR! This looks like a pretty clear cut bug, and the fix looks good. It'd be a good idea to add an RSpec test that replicates this issue so we can confirm the efficacy of the change, and prevent any regressions. Once we have one of those, I think we can merge this one. |
|
@delner thanks for the feedback! Will add tests for it. |
1b342cf to
4df99f4
Compare
4df99f4 to
708f4f0
Compare
|
@delner Added some rspec unit tests. There were already some tests for workers in Let me know if this is enough, or you'd prefer it any other way. |
|
Yup, RSpec is what we prefer anyways, so that's all good! I'll take a look. |
delner
left a comment
There was a problem hiding this comment.
Looks good! Thanks for your contribution! This will roll with 0.13.1.
When running the gem in production, we came across the following error:
And noticed that this commit changed the variable name in the method body but not in the rescue block.
This PR updates the variable names to the proper ones in rescue blocks.