Bump to version 0.13.0 #470
Conversation
pawelchcki
force-pushed
the
bump_to_version_0.13.0
branch
from
35e860d
to
667de07
Compare
CHANGELOG.md
Outdated
| - Request and response header tags to Rack (#389) | ||
| - MySQL2 integration (#453) (@jamiehodge) | ||
| - Sidekiq tag job delay (#458) (@gottfrois) | ||
| - Sinatra tag request id (#427) |
There was a problem hiding this comment.
I don't think we actually added a request_id tag at all. We added "Request and response headers to Sinatra". This also needs to list #375.
There was a problem hiding this comment.
We do tag request id, but its because its listed as one of the default headers we tag. Yeah but you're right the description needs to be expanded
There was a problem hiding this comment.
Well what we did for Sinatra is consistent with what we did for Rack. So the comment should probably look the same.
CHANGELOG.md
Outdated
| - ActiveSupport::Notifications::Event helper for event tracing (#400) | ||
| - Request and response header tags to Rack (#389) | ||
| - MySQL2 integration (#453) (@jamiehodge) | ||
| - Sidekiq tag job delay (#458) (@gottfrois) |
There was a problem hiding this comment.
😱 Thanks for spotting that !
CHANGELOG.md
Outdated
|
|
||
| ### Fixed | ||
|
|
||
| - Excon close spans on errors (#426) (@jeffjo) |
There was a problem hiding this comment.
We usually do not list fixes for things that are being released for the first time. Let's remove this line, merge both the PR and the author into "Excon integration" above.
pawelchcki
force-pushed
the
bump_to_version_0.13.0
branch
2 times, most recently
from
e37fc3c
to
7d3915d
Compare
CHANGELOG.md
Outdated
| - Sequel integration (supporting Ruby 2.0+) (#171, #367) (@randy-girard, @twe4ked, @palin) | ||
| - gRPC integration (supporting Ruby 2.2+) (#379, #403) (@Jared-Prime) | ||
| - ActiveModelSerializers integration (#340) (@sullimander) | ||
| - Excon integration (#211, #426) (@walterking,@jeffjo) |
There was a problem hiding this comment.
Need to add a space between the names.
pawelchcki
force-pushed
the
bump_to_version_0.13.0
branch
from
7d3915d
to
2f53e51
Compare
No description provided.