DEBUG-2334 remove unused method stubs from DI test suite #4107
+0
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-11-13 03:34:38 Comparing candidate commit 39da4d8 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics. scenario:profiler - sample timeline=false
|
sarahchen6
approved these changes
Nov 13, 2024
p-datadog
pushed a commit
that referenced
this pull request
Nov 15, 2024
* origin/di-virtual: (30 commits) DEBUG-2334 Ruby 2 compatibility for dynamic instrumentation (#4120) Fix CI flakiness by adding dockerhub login Update filter with splitted gemfile and task [🤖] Lock Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/11846139851 Lock sqlite3 Lock ActiveRecord Fix deprecation behavior Fix trilogy/patcher_spec Update 3.4_relational_db.gemfile Update Ruby 3.4 Gemfile Add 3.4 to circleci DEBUG-2334 Use :return/:b_return trace points to target 'end' line of methods and blocks with line probes (#4109) Temporarily disable asan ruby job Update developement guide Lint Fix release_gem_spec.rb Gemfile migration Update usage Appraisal group generation replacement DEBUG-2334 remove unused method stubs from DI test suite (#4107) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes
allowcalls from test suite for the relocatedpropagate_all_exceptionssetting.Motivation:
Test suite cleanup.
Change log entry
None
Additional Notes:
How to test the change?