-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rake instrumentation #409
Conversation
ff03559
to
35ad3a5
Compare
This depends on #410: that PR should be merged before this one. |
35ad3a5
to
e3f0415
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great contribution! I think we only need to add documentation and it's ready to be merged!
@palazzem Ah, right. Will do that. |
e3f0415
to
fcba946
Compare
@palazzem Added some documentation, but discovered some issues with the quantization options. Added tests and a fix for that, and changed the tags a bit. Should be good for another review now. |
Flaky gRPC tests are preventing the test build from passing right now. |
…e.execute.args`.
fcba946
to
511420f
Compare
This pull request adds instrumentation for Rake. Each task will generate spans named either
rake.invoke
,rake.execute
, or both, depending on how the task runs.To enable this, you must add the following to your
Rakefile
:Screenshot of a
db:migrate
task in action: