Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rake instrumentation #409

Merged
merged 6 commits into from
May 2, 2018
Merged

Conversation

delner
Copy link
Contributor

@delner delner commented Apr 25, 2018

This pull request adds instrumentation for Rake. Each task will generate spans named either rake.invoke, rake.execute, or both, depending on how the task runs.

To enable this, you must add the following to your Rakefile:

# Rakefile
require 'ddtrace'

Datadog.configure do |c|
  c.use :rake, service_name: 'dd_test-rake'
end

# Define your rake tasks here...

Screenshot of a db:migrate task in action:

screen shot 2018-04-30 at 1 57 00 pm

@delner delner added integrations Involves tracing integrations do-not-merge/WIP Not ready for merge feature Involves a product feature labels Apr 25, 2018
@delner delner added this to the 0.13.0 milestone Apr 25, 2018
@delner delner self-assigned this Apr 25, 2018
@delner delner requested a review from palazzem April 25, 2018 21:21
@delner delner force-pushed the feature/add_rake_instrumentation branch 2 times, most recently from ff03559 to 35ad3a5 Compare April 26, 2018 18:51
@delner
Copy link
Contributor Author

delner commented Apr 26, 2018

This depends on #410: that PR should be merged before this one.

@palazzem palazzem force-pushed the feature/add_rake_instrumentation branch from 35ad3a5 to e3f0415 Compare April 30, 2018 09:59
@palazzem
Copy link
Contributor

@delner #410 merged and this one rebased on top of 0.13-dev. Reviewing it now!

@palazzem palazzem removed the do-not-merge/WIP Not ready for merge label Apr 30, 2018
Copy link
Contributor

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! I think we only need to add documentation and it's ready to be merged!

@delner
Copy link
Contributor Author

delner commented Apr 30, 2018

@palazzem Ah, right. Will do that.

@delner delner force-pushed the feature/add_rake_instrumentation branch from e3f0415 to fcba946 Compare April 30, 2018 17:43
@delner
Copy link
Contributor Author

delner commented Apr 30, 2018

@palazzem Added some documentation, but discovered some issues with the quantization options. Added tests and a fix for that, and changed the tags a bit. Should be good for another review now.

@delner
Copy link
Contributor Author

delner commented Apr 30, 2018

Flaky gRPC tests are preventing the test build from passing right now.

@delner delner force-pushed the feature/add_rake_instrumentation branch from fcba946 to 511420f Compare May 1, 2018 17:13
@delner delner merged commit 3d1905b into 0.13-dev May 2, 2018
@delner delner deleted the feature/add_rake_instrumentation branch May 2, 2018 15:38
delner added a commit that referenced this pull request May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Involves a product feature integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants