-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEBUG-2334 DI internal settings reorg + telemetry + error handling #4089
Merged
+325
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4089 +/- ##
==========================================
+ Coverage 97.74% 97.79% +0.05%
==========================================
Files 1341 1341
Lines 80356 80408 +52
Branches 4030 4048 +18
==========================================
+ Hits 78541 78637 +96
+ Misses 1815 1771 -44 ☔ View full report in Codecov by Sentry. |
y9v
approved these changes
Nov 12, 2024
p-datadog
added
the
dev/internal
Other internal work that does not need to be included in the changelog
label
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR contains part of #4063 that modifies files already in master.
Motivation:
Test failures in #4063 are difficult to troubleshoot, this PR extracts code that can be merged without needing non-DI changes to help with the troubleshooting.
Change log entry
None
Additional Notes:
How to test the change?
Unit tests