[NO-TICKET] Fix rubocop lint #4062
Merged
+26
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR moves the `start_worker` and `stop_worker` to the `private` section of `writer.rb`. It does this instead of using `private :start_worker, :stop_worker` to make rubocop happy. **Motivation:** Unbreak rubocop in master. **Additional Notes:** I thought we had pinned down the version of rubocop in CI, but it appears we have a gap. I've not investigated further. **How to test the change?** Validate that the lint check in CI is back to green.
ivoanjo
added
dev/testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4062 +/- ##
=======================================
Coverage 97.72% 97.73%
=======================================
Files 1338 1338
Lines 80249 80249
Branches 4016 4016
=======================================
+ Hits 78422 78429 +7
+ Misses 1827 1820 -7 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-11-04 13:34:00 Comparing candidate commit f208359 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. |
TonyCTHsu
approved these changes
Nov 4, 2024
zarirhamza
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR moves the
start_workerandstop_workerto theprivatesection ofwriter.rb.It does this instead of using
private :start_worker, :stop_workerto make rubocop happy.Motivation:
Unbreak rubocop in master.
Change log entry
(Not relevant)
Additional Notes:
I thought we had pinned down the version of rubocop in CI, but it appears we have a gap. I've not investigated further.
How to test the change?
Validate that the lint check in CI is back to green.