Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove benchmarks never ran. #3949

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

TonyCTHsu
Copy link
Contributor

What does this PR do?

Those benchmarks are skipped and never ran.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (7cfcefb) to head (4466958).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3949      +/-   ##
==========================================
+ Coverage   97.84%   97.86%   +0.01%     
==========================================
  Files        1307     1305       -2     
  Lines       78289    78235      -54     
  Branches     3895     3893       -2     
==========================================
- Hits        76604    76564      -40     
+ Misses       1685     1671      -14     
Flag Coverage Δ
97.86% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Sep 25, 2024

Benchmarks

Benchmark execution time: 2024-09-26 11:08:42

Comparing candidate commit 4466958 in PR branch tonycthsu/remove-obsolete-test with baseline commit 7cfcefb in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

@TonyCTHsu TonyCTHsu marked this pull request as ready for review September 25, 2024 12:15
@TonyCTHsu TonyCTHsu requested review from a team as code owners September 25, 2024 12:15
@TonyCTHsu TonyCTHsu added the dev/testing Involves testing processes (e.g. RSpec) label Sep 25, 2024
Copy link
Contributor

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TonyCTHsu TonyCTHsu merged commit fa61ea2 into master Sep 26, 2024
196 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/remove-obsolete-test branch September 26, 2024 11:14
@github-actions github-actions bot added this to the 2.4.0 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants