Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable lazy sampling #3947

Merged
1 commit merged into from
Oct 7, 2024
Merged

feat: enable lazy sampling #3947

1 commit merged into from
Oct 7, 2024

Conversation

ZStriker19
Copy link
Contributor

What does this PR do?
By not sampling at span start we are essentially enabling lazy sampling once the groundwork has been merged:
#3945
#3946

Motivation:
By enabling lazy sampling we can sample on tags and resource

Additional Notes:

How to test the change?

Unsure? Have a question? Request a review!

@marcotc marcotc closed this pull request by merging all changes into master in 9e26192 Oct 7, 2024
@marcotc marcotc deleted the zachg/remove_sampling_at_span_start branch October 7, 2024 19:34
@github-actions github-actions bot added this to the 2.4.0 milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants