DEBUG-2334 make serialize_value of Serializer public and add test cov… #3925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erage For serializing method return values, we will need to call serialize_value from outside of Serializer and this call will not have a name provided. Make serialize_value public and add some tests for it (simple cases that were under serialize_vars previously + explicit redaction cases).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3925 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 1291 1291
Lines 77149 77166 +17
Branches 3810 3810
=======================================
+ Hits 75440 75457 +17
Misses 1709 1709 ☔ View full report in Codecov by Sentry. |
y9v
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erage
What does this PR do?
Make serialize_value public and add some tests for it (simple cases that were under serialize_vars previously + explicit redaction cases).
Motivation:
For serializing method return values, we will need to call serialize_value from outside of Serializer and this call will not have a name provided.
Additional Notes:
How to test the change?
Unit tests.
Unsure? Have a question? Request a review!