Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing RC capabilities #3888

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Add missing RC capabilities #3888

merged 4 commits into from
Sep 11, 2024

Conversation

zarirhamza
Copy link
Contributor

@zarirhamza zarirhamza commented Sep 4, 2024

This PR reports dynamic configuration capabilities that are already supported, but were not reported as such. These missing capabilities are: APM_TRACING_SAMPLE_RATE, APM_TRACING_LOGS_INJECTION, APM_TRACING_HTTP_HEADER_TAGS.

How to test the change?
System tests have been enabled for these capabilities: DataDog/system-tests#3011

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Sep 4, 2024

Benchmarks

Benchmark execution time: 2024-09-11 15:55:47

Comparing candidate commit ee1a9ff in PR branch zarir/rc-config-add with baseline commit bc84181 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

@marcotc marcotc marked this pull request as ready for review September 10, 2024 22:51
@marcotc marcotc requested a review from a team as a code owner September 10, 2024 22:51
@marcotc marcotc changed the title Adds more RC configs Adds missing RC configs Sep 10, 2024
@marcotc marcotc changed the title Adds missing RC configs Add missing RC capabilities Sep 10, 2024
@zarirhamza zarirhamza requested a review from a team as a code owner September 11, 2024 15:19
@zarirhamza zarirhamza enabled auto-merge (squash) September 11, 2024 15:37
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (bc84181) to head (ee1a9ff).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3888      +/-   ##
==========================================
+ Coverage   97.84%   97.86%   +0.01%     
==========================================
  Files        1279     1279              
  Lines       76530    76529       -1     
  Branches     3752     3752              
==========================================
+ Hits        74883    74893      +10     
+ Misses       1647     1636      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcotc marcotc merged commit 7dbcc40 into master Sep 11, 2024
191 checks passed
@marcotc marcotc deleted the zarir/rc-config-add branch September 11, 2024 20:49
@TonyCTHsu TonyCTHsu added this to the 2.4.0 milestone Sep 20, 2024
@y9v y9v mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants