-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing RC capabilities #3888
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
p-datadog
approved these changes
Sep 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3888 +/- ##
==========================================
+ Coverage 97.84% 97.86% +0.01%
==========================================
Files 1279 1279
Lines 76530 76529 -1
Branches 3752 3752
==========================================
+ Hits 74883 74893 +10
+ Misses 1647 1636 -11 ☔ View full report in Codecov by Sentry. |
y9v
approved these changes
Sep 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reports dynamic configuration capabilities that are already supported, but were not reported as such. These missing capabilities are:
APM_TRACING_SAMPLE_RATE
,APM_TRACING_LOGS_INJECTION
,APM_TRACING_HTTP_HEADER_TAGS
.How to test the change?
System tests have been enabled for these capabilities: DataDog/system-tests#3011
Unsure? Have a question? Request a review!