Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system tests #3883

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix system tests #3883

merged 1 commit into from
Sep 5, 2024

Conversation

p-datadog
Copy link
Contributor

Add build-harness and build-apps to the list of needs for aggregate job so it won't run if a build job fails

Add build-harness and build-apps to the list of needs
for aggregate job so it won't run if a build job fails
@p-datadog p-datadog requested a review from a team as a code owner September 3, 2024 18:20
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Sep 3, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.85%. Comparing base (ae50107) to head (805772d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3883      +/-   ##
==========================================
- Coverage   97.85%   97.85%   -0.01%     
==========================================
  Files        1277     1277              
  Lines       76392    76392              
  Branches     3744     3744              
==========================================
- Hits        74757    74753       -4     
- Misses       1635     1639       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Sep 3, 2024

Benchmarks

Benchmark execution time: 2024-09-03 19:01:04

Comparing candidate commit 805772d in PR branch fix-system-tests-2 with baseline commit ae50107 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

@p-datadog
Copy link
Contributor Author

I will merge this and it looks like #3886 is attempting to repair the ASM test failures.

@p-datadog p-datadog merged commit 27d462b into master Sep 5, 2024
189 of 191 checks passed
@p-datadog p-datadog deleted the fix-system-tests-2 branch September 5, 2024 17:26
p-datadog pushed a commit to p-datadog/dd-trace-rb that referenced this pull request Sep 6, 2024
* master:
  Add a check that ruleset file still exists to appsec:ruleset:update
  Add argument presence checks for appsec:ruleset:update
  Add Github Token as argument to appsec:ruleset:update task
  Add comments about deadlock risk
  Refactor with default level
  Refactor with Logger module
  DEBUG-2334 default token bucket allow? size to 1 (DataDog#3882)
  Fix system tests (DataDog#3883)
  Inject telemetry component
  Update gemfiles/*
  Add fiddle gem to Gemfile for Ruby >= 3.3
  Add ostruct to Gemfile for Ruby >= 3.3
@anmarchenko anmarchenko added this to the 2.4.0 milestone Sep 9, 2024
y9v pushed a commit that referenced this pull request Sep 13, 2024
Add build-harness and build-apps to the list of needs
for aggregate job so it won't run if a build job fails

Co-authored-by: Oleg Pudeyev <code@olegp.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants