Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add http.route tag to rails, grape, and sinatra integrations #3849

Merged
merged 38 commits into from
Sep 19, 2024
Merged

Add http.route tag to rails, grape, and sinatra integrations #3849

merged 38 commits into from
Sep 19, 2024

Commits on Aug 26, 2024

  1. Add http.route to rails journey router

    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    be47189 View commit details
    Browse the repository at this point in the history

  2. Add http.route tag to sinatra route span

    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    0cc1427 View commit details
    Browse the repository at this point in the history

  3. Add comment to Journey::Router instrumentation

    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    632e687 View commit details
    Browse the repository at this point in the history

  4. Fix http route identification for rails engines

    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8e4df61 View commit details
    Browse the repository at this point in the history

  5. Fix version checking for ActionPack patcher 

    We are not loading Rails in specs for this patcher, and we should check
`ActionPack` version instead.
    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    fc667ff View commit details
    Browse the repository at this point in the history

  6. Add type signatures for action pack patcher and instrumentation

    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8c96b50 View commit details
    Browse the repository at this point in the history

  7. Add http.route to Grape

    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4014673 View commit details
    Browse the repository at this point in the history

  8. Add integration tests for Rails journey router patch

    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    7d47f3e View commit details
    Browse the repository at this point in the history

  9. Fix comment in rails 7 spec support file

    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    73d5706 View commit details
    Browse the repository at this point in the history

  10. Add rails7 spec helper file to rubocop ignore list

    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    3cd9d3e View commit details
    Browse the repository at this point in the history

  11. Remove active_job require from Journey test

    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    7bd59cb View commit details
    Browse the repository at this point in the history

  12. Fix rails configuration spec helpers

    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    aa4cf48 View commit details
    Browse the repository at this point in the history

  13. Fix engine route handling for rails < 7.1

    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ec064d8 View commit details
    Browse the repository at this point in the history

  14. Fix sinatra integration 

    We want to put http.route tag on rack.request span, not on sinatra
spans.
    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ba280ac View commit details
    Browse the repository at this point in the history

  15. Disable datadog static analysis for rails 7 spec helper

    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    40f02e4 View commit details
    Browse the repository at this point in the history

  16. Fix checking of route presence in ActionDispatch instrumentation

    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    30c9362 View commit details
    Browse the repository at this point in the history

  17. Add appraisals for action_pack 

    Rails router changed it's internals in 7.1 and it makes sense to test
our integration against multiple ActionPack versions.
    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    bb72ebc View commit details
    Browse the repository at this point in the history

  18. Remove ::set_http_route_tag and add a method to format the route

    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    0bdc2b9 View commit details
    Browse the repository at this point in the history

  19. Fix Journey router instrumentation test description

    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ddb1ccd View commit details
    Browse the repository at this point in the history

  20. Remove actionpack appraisal 

    We want to reuse rails appraisals for testing actionpack to reduce the
amount of appraisals we have.
    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    5ba0fef View commit details
    Browse the repository at this point in the history

  21. Fix Matrixfile for ruby 2.x for actionpack

    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    7609f54 View commit details
    Browse the repository at this point in the history

  22. Add http.route tag setting to rack middleware as fallback

    @y9v
    y9v committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2a6130d View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Change patching of journey router for rails > 7.1 

    We don't want to patch #find_routes method instead of #serve method for rails > 7.1,
to make sure that we are setting the http.route tag as early as
possible.
    @y9v
    y9v committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    079872b View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Add handling of ambiguous rails routes with constraints

    @y9v
    y9v committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    60ceee4 View commit details
    Browse the repository at this point in the history

  2. Add handling for rack applications mounted in Rails

    @y9v
    y9v committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    2e3a70b View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Add concatenation of route and script name to rack middleware

    @y9v
    y9v committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    d5bbc94 View commit details
    Browse the repository at this point in the history

  2. Use a constant in rack http route specs

    @y9v
    y9v committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    4b6f5ed View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into add-http-route

    @y9v
    y9v committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    8a42cc1 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Improve configuration reset in specs

    @y9v
    y9v committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    cae659f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into add-http-route

    @y9v
    y9v committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    df0bd9a View commit details
    Browse the repository at this point in the history

  3. Improve rack instrumentation and specs

    @y9v
    y9v committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3207b16 View commit details
    Browse the repository at this point in the history

  4. Update gemfiles/*

    @y9v @github-actions
    y9v authored and github-actions[bot] committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    81217b9 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Change around(:example) to around(:suite) for rack http route test

    @y9v
    y9v committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    fedd3e3 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Fix route path tag in rack, improve grape route instrumentation code

    @y9v
    y9v committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7317018 View commit details
    Browse the repository at this point in the history

  2. Add a comment to grape endpoint explaining route format removal

    @y9v
    y9v committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c62c24d View commit details
    Browse the repository at this point in the history

  3. Add handling for possible nil value of env['SCRIPT_NAME']

    @y9v
    y9v committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    b72916c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into add-http-route

    @y9v
    y9v committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    704eb19 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Remove debugging code

    @y9v
    y9v committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    deaba02 View commit details
    Browse the repository at this point in the history