Fix GraphQL patchers 'require' issue

[vpellan]

What does this PR do?

Making a custom tracer based on unified_tracer should now not need to require explicitly the unified_tracer.rb file anymore. This also fixes the problem with currently unreleased appsec_tracer.

Motivation:

Fixes issue #3804

Additional Notes:

How to test the change?

Create a Rails + GraphQL app with a custom tracer that includes unified_tracer. GraphQL AppSec test app is using this so if system-tests passes, it works.

Unsure? Have a question? Request a review!

[p-datadog]

Is it supported to load datadog first and graphql second, as well as the other way around?

We already have tests like https://github.com/DataDog/dd-trace-rb/blob/master/spec/loading_spec.rb that start with a clean environment, given that this was a customer-reported issue I would consider adding a test that verifies that the reported case works correctly going forward.

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-08-05 18:32:43

Comparing candidate commit 6f6ce3e in PR branch vpellan/graphql-unified-tracer-require with baseline commit 4fbe269 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

[vpellan]

Is it supported to load datadog first and graphql second, as well as the other way around?

We already have tests like master/spec/loading_spec.rb that start with a clean environment, given that this was a customer-reported issue I would consider adding a test that verifies that the reported case works correctly going forward.

Hello! Thanks for the suggestions.
I've added a test that will require datadog first, then graphql, and the other way too.
I've also added a test for trace_with.

[p-datadog]

I would think that adding require 'shellwords' in this file is necessary so that it can be executed by itself? The only other place that requires this library is the top-level loading test that I can see.

[vpellan]

Thanks for the suggestion, I've added it !

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 88.59060% with 17 lines in your changes missing coverage. Please review.

Project coverage is 97.86%. Comparing base (4fbe269) to head (6f6ce3e).
Report is 1 commits behind head on master.

Files	Patch %	Lines
...cing/contrib/graphql/support/application_schema.rb	72.58%	17 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3813      +/-   ##
==========================================
- Coverage   97.87%   97.86%   -0.01%     
==========================================
  Files        1262     1263       +1     
  Lines       75653    75738      +85     
  Branches     3710     3719       +9     
==========================================
+ Hits        74044    74124      +80     
- Misses       1609     1614       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.