[PROF-10208] Upgrade to libdatadog 11 #3799
Merged
+1,104
−1,101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR upgrades the datadog gem to use libdatadog 11. There were some minor tweaks needed in the crashtracker APIs, but otherwise it's a drop-in upgrade. **Motivation:** Staying on the latest libdatadog enables us to pick up the latest improvements and also makes it easier to develop new features that need libdatadog changes. **Additional Notes:** As usual, I'm opening this PR as a draft as libdatadog 11 is not yet available on rubygems.org, and I'll come back to re-trigger CI and mark this as non-draft once it is. **How to test the change?** Our existing test coverage includes libdatadog testing, so a green CI is good here :)
ivoanjo
added a commit
to DataDog/libdatadog
that referenced
this pull request
Jul 22, 2024
# What does this PR do? This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg The v11 version bump PR (#529) had already bumped the version itself, so I just needed to add the hashes. # Motivation Enable Ruby to use libdatadog v11.0.0. # Additional Notes N/A # How to test the change? I've tested this release locally using the changes in DataDog/dd-trace-rb#3799 . As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.
ivoanjo
added a commit
to DataDog/libdatadog
that referenced
this pull request
Jul 22, 2024
# What does this PR do? This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg The v11 version bump PR (#529) had already bumped the version itself, so I just needed to add the hashes. # Motivation Enable Ruby to use libdatadog v11.0.0. # Additional Notes N/A # How to test the change? I've tested this release locally using the changes in DataDog/dd-trace-rb#3799 . As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.
ivoanjo
force-pushed
the
ivoanjo/prof-10208-libdatadog11-upgrade
branch
from
e93e8a6
to
d3f1ac4
Compare
BenchmarksBenchmark execution time: 2024-07-22 14:02:40 Comparing candidate commit d3f1ac4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. |
anmarchenko
approved these changes
Jul 22, 2024
ekump
pushed a commit
to DataDog/libdatadog
that referenced
this pull request
Jul 22, 2024
# What does this PR do? This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg The v11 version bump PR (#529) had already bumped the version itself, so I just needed to add the hashes. # Motivation Enable Ruby to use libdatadog v11.0.0. # Additional Notes N/A # How to test the change? I've tested this release locally using the changes in DataDog/dd-trace-rb#3799 . As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR upgrades the datadog gem to use libdatadog 11.
There were some minor tweaks needed in the crashtracker APIs, but otherwise it's a drop-in upgrade.
Motivation:
Staying on the latest libdatadog enables us to pick up the latest improvements and also makes it easier to develop new features that need libdatadog changes.
Additional Notes:
As usual, I'm opening this PR as a draft as libdatadog 11 is not yet available on rubygems.org, and I'll come back to re-trigger CI and mark this as non-draft once it is.
How to test the change?
Our existing test coverage includes libdatadog testing, so a green CI is good here :)