[PROF-10198] Add benchmark config with allocation profiling + ddprof #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR adds a new benchmarking configuration for testing allocation profiling with `ddprof` enabled. (As a reminder, `ddprof` is the Datadog native profiler). **Motivation:** The intention is to allow us to use ddprof to profile the Ruby profiler, so we can identify optimization opportunities and validate any changes we make. **Additional Notes:** N/A **How to test the change?** I've tested this PR locally using the `bp-runner` tool.
marcotc
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new benchmarking configuration for testing allocation profiling with
ddprofenabled.(As a reminder,
ddprofis the Datadog native profiler).Motivation:
The intention is to allow us to use ddprof to profile the Ruby profiler, so we can identify optimization opportunities and validate any changes we make.
Additional Notes:
N/A
How to test the change?
I've tried to test this PR locally using the
bp-runnertool, but for some reason I get benchmark results, but no profiles. Nevertheless, this change is harmless so I'm thinking of merging this in and seeing if it shows up correctly on the next nightly run.