[PROF-10015] Fix Phusion Passenger detection when not in Gemfile
/gems.rb
#3750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In #2978 because of an incompatibility with Phusion Passenger, we added autodetection code to enable the "no signals" workaround when this web server is in use.
This code was later extended in #3280 once an upstream fix was released, so that the "no signals" workaround was only applied on old Passenger versions.
But in #3721 we got a report that our version detection code did not work correctly in setups where Passenger was not installed via
Gemfile
/gems.rb
.This PR fixes the version detection in these situations.
Motivation:
Make sure the "no signals" workaround does not get enabled in setups where it does not need to be.
Additional Notes:
N/A
How to test the change?
I've added test coverage for this issue.
Additionally, here's how to manually install Passenger and validate that the "no signals" workaround does not get enabled:
in master this outputs the warning message
With this fix, this message is not shown, confirming the "no signals" workaround is not enabled.