Populate ActiveSupport Notification spans as early as possible #3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Costa <marco.costa@datadoghq.com>
TonyCTHsu
reviewed
Jun 19, 2024
lib/datadog/tracing/contrib/active_support/notifications/subscription.rb
Outdated
Show resolved
Hide resolved
lib/datadog/tracing/contrib/active_support/notifications/subscription.rb
Outdated
Show resolved
Hide resolved
TonyCTHsu
approved these changes
Jun 20, 2024
|
❤️ Adding info to spans as early as possible also opens up possibilities for the profiler to do more with this data so thanks for all this work :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2846
This PR populates spans create it from ActiveSupport Notification spans as early as possible.
Before this PR, a span was started when the ActiveSupport Notification event started but the notification callback was only called when the event ended. This meant that during the event execution, the active span would not have all its fields populated.
This causes issues with children span's service entry detection and service name propagation.
How to test the change?
All changes are covered by tests.