Fix HTTPTransport sampling callback for services #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
bug
|
@delner in which point it's considered a breaking change? can you update the description stating in clear where it requires a user change? |
|
@palazzem I'm actually not sure it is a breaking change. I might have accidentally tagged that instead of WIP (same color.) Will double check though. |
delner
force-pushed
the
bugfix/transport_services_response_parsing
branch
from
391f86c
to
74f94df
Compare
palazzem
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If priority sampling is enabled, and HTTPTransport attempts to write service spans to the agent, it will trigger the sampling updater callback which will try to process the services response (which is
OK) as a traces response (which is JSON), resulting in lots of parse errors.This pull request passes the action as a parameter to the callback, so it can use that information to change how it handles responses.
Should be rebased and merged after #369.
Side note; this should probably be considered a stop-gap measure. There's a lot of coupling between Writer, Transport, and the concept of "API" which makes this design fairly brittle. Would recommend a refactor in the future.