Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parametric system-tests workflow #3698

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vpellan
Copy link
Contributor

@vpellan vpellan commented Jun 10, 2024

What does this PR do?

This PR adds a GitHub workflow for parametrics system-tests

Motivation:

The SCA Env Var system-tests is run as a parametric test, and I wanted to test it on the CI.

Additional Notes:

The FORCE_TESTS env var does not work as the -F option on system-tests only work for the DEFAULT scenario right now.
There are currently 4 tests that needs to be fixed:

  • tests/parametric/test_dynamic_configuration.py::TestDynamicConfigSamplingRules::test_trace_sampling_rules_with_tags
  • tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_span_started_with_link_from_datadog_headers
  • tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_span_started_with_link_from_w3c_headers
  • tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_span_started_with_link_from_other_spans

@vpellan vpellan self-assigned this Jun 10, 2024
@vpellan vpellan requested a review from a team as a code owner June 10, 2024 13:18
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Jun 10, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (eab4b6e) to head (eddd956).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3698   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files        1225     1225           
  Lines       72743    72743           
  Branches     3479     3479           
=======================================
  Hits        71369    71369           
  Misses       1374     1374           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

run: TEST_LIBRARY=ruby ./run.sh PARAMETRIC ${{ env.FORCE_TESTS }}
- name: Compress logs
id: compress_logs
if: always()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants