Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a mechanism to set multiple envs per configuration #3679

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jun 4, 2024

What does this PR do?

  • Updates OptionDefintion.env to accept a list of environment variables. With this change dd-trace-rb contributors can supply multiple envars for each configuration (in order of precedence).
  • Introduces resolved_env instance method for the Options class. This will allow developers to detect which environment variable were used to set a configuration.

Motivation:

Additional Notes:

How to test the change?

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the core Involves Datadog core libraries label Jun 4, 2024
@mabdinur mabdinur changed the title chore: add a mechanism to set multiple envs chore: add a mechanism to set multiple envs per configuration Jun 4, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (f7a8fb5) to head (7b60462).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3679      +/-   ##
==========================================
- Coverage   98.11%   98.10%   -0.01%     
==========================================
  Files        1225     1225              
  Lines       72519    72543      +24     
  Branches     3446     3448       +2     
==========================================
+ Hits        71149    71171      +22     
- Misses       1370     1372       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mabdinur mabdinur marked this pull request as ready for review June 4, 2024 21:16
@mabdinur mabdinur requested a review from a team as a code owner June 4, 2024 21:16
@mabdinur mabdinur requested a review from delner June 4, 2024 21:16
@mabdinur mabdinur added this to the 2.1.0 milestone Jun 5, 2024
@mabdinur mabdinur requested a review from zarirhamza June 7, 2024 14:17
@zarirhamza zarirhamza enabled auto-merge (squash) June 7, 2024 20:33
@zarirhamza zarirhamza merged commit 70e7fc4 into master Jun 7, 2024
142 of 145 checks passed
@zarirhamza zarirhamza deleted the munir/options-track-multiple-configs branch June 7, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants