Remaps http status code tag for otel span for trace metrics #3664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
approved these changes
May 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3664 +/- ##
==========================================
- Coverage 98.10% 98.10% -0.01%
==========================================
Files 1225 1225
Lines 72472 72485 +13
Branches 3443 3446 +3
==========================================
+ Hits 71101 71112 +11
- Misses 1371 1373 +2 ☔ View full report in Codecov by Sentry. |
marcotc
approved these changes
May 28, 2024
p-datadog
pushed a commit
to p-datadog/dd-trace-rb
that referenced
this pull request
Jun 4, 2024
* master: (22 commits) Remove experimental warning from OpenTelemetry.md Remove latest tag on docker images add installer system tests Extract trace id format helper method (DataDog#3670) Remaps http status code tag for otel span for trace metrics (DataDog#3664) Update .github/labeler.yml Use 3.20 rb -> ruby Add a note about `use` vs `instrument` GitHub: Update labeller bot with new products Update lockfiles for release 2.0.0.rc1 Bump version 2.0.0.beta2 to 2.0.0.rc1 Add 2.0.0.rc1 to CHANGELOG.md chore(lib-injection): update base image to alpine 3.18.6 Apply suggestions from code review Revert "DEBUG-2334 Add Debugger component (DataDog#3640)" Implement `latest_major` and `lastest_minor` tag for docker init container (DataDog#3643) Build oci package Update `rexml` (DataDog#3656) Remove bundler cache in for `setup-ruby` step and pin bundler and rubygem version ...
Merged
p-datadog
pushed a commit
to p-datadog/dd-trace-rb
that referenced
this pull request
Jun 6, 2024
* master-merge-to-di: (37 commits) Revert "Revert "DEBUG-2334 Add Debugger component (DataDog#3640)"" Update lockfiles for release 2.0.0 Bump version 2.0.0.rc1 to 2.0.0 Add 2.0.0 to CHANGELOG.md Add missing Apache 2.0 license from gemspec Use ffi 1.16.3 Add platform Output gem version Output debug logs Fix spec to exclude .vscode directory Fix docker run command Add vscode settings for dockerfile file associations Update gem version Update gemfiles/* Update `ffi` in Gemfile Remove experimental warning from OpenTelemetry.md Remove latest tag on docker images add installer system tests Extract trace id format helper method (DataDog#3670) Remaps http status code tag for otel span for trace metrics (DataDog#3664) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
http.response.status_codeto be remapped tohttp.status_codefor trace metrics for otel spans