-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
w3c(phase 3): ensure last datadog parent id is always recorded #3631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabdinur
commented
May 9, 2024
mabdinur
commented
May 9, 2024
mabdinur
commented
May 9, 2024
mabdinur
force-pushed
the
munir/w3c-phase-3
branch
from
May 14, 2024 18:14
c6de4f0
to
fc8c409
Compare
mabdinur
commented
May 17, 2024
mabdinur
commented
May 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3631 +/- ##
==========================================
- Coverage 98.13% 98.13% -0.01%
==========================================
Files 1223 1223
Lines 72115 72185 +70
Branches 3424 3435 +11
==========================================
+ Hits 70768 70836 +68
- Misses 1347 1349 +2 ☔ View full report in Codecov by Sentry. |
marcotc
approved these changes
Jun 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensures when trace headers with the same trace_id but different span_ids are received by an application the tracecontext headers are treated as the source of truth.
_dd.parent_id
parent_id tag.This behavior will be validated by the following system-tests: DataDog/system-tests#2385
Motivation:
Provide first class support for services instrumented with opentelemetry and reduce instances of "broken traces".
Additional Notes:
How to test the change?
Unsure? Have a question? Request a review!