[NO-TICKET] Remove profiler support for Ruby 2.3 and 2.4 #3621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR removes the code for supporting Ruby 2.3 and 2.4 from the profiler. This matches the minimum version for the datadog gem which is now Ruby 2.5 (e.g. this was dead code -- you couldn't actually use it anymore). **Motivation:** We opted not to do this earlier on in the 2.x release cycle, but as we are getting close to the final release, and given that the diff is not that big, I decided to go ahead and do it now. **Additional Notes:** In some cases, because a conditional was removed, indentation was adjusted. I suggest reviewing this diff with "Hide whitespace" turned on (or `-w` in the git cli). In ddtrace 1.x, the gem supported Ruby 2.1+ whereas the profiler was supporting 2.3+. We still had some awkward support code to deal with this difference, which I also went ahead and removed. It's cool in particular to see `private_vm_api_access.c` shrinking. I'm looking forward to this trend continuing, and maybe one day we'll even be able to remove it completely :) **How to test the change?** Validate that CI is still green on supported Rubies.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3621 +/- ##
=======================================
Coverage 98.12% 98.13%
=======================================
Files 1223 1223
Lines 72136 72121 -15
Branches 3425 3419 -6
=======================================
- Hits 70787 70775 -12
+ Misses 1349 1346 -3 ☔ View full report in Codecov by Sentry. |
AlexJF
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the code for supporting Ruby 2.3 and 2.4 from the profiler.
This matches the minimum version for the datadog gem which is now Ruby 2.5 (e.g. this was dead code -- you couldn't actually use it anymore).
Motivation:
We opted not to do this earlier on in the 2.x release cycle, but as we are getting close to the final release, and given that the diff is not that big, I decided to go ahead and do it now.
Additional Notes:
In some cases, because a conditional was removed, indentation was adjusted. I suggest reviewing this diff with "Hide whitespace" turned on (or
-win the git cli).In ddtrace 1.x, the gem supported Ruby 2.1+ whereas the profiler was supporting 2.3+. We still had some awkward support code to deal with this difference, which I also went ahead and removed.
It's cool in particular to see
private_vm_api_access.cshrinking. I'm looking forward to this trend continuing, and maybe one day we'll even be able to remove it completely :)How to test the change?
Validate that CI is still green on supported Rubies.