[PROF-8917] Misc fixes from crashtracker branch #3517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having access to the version will come in handy in the crash tracker branch, and in general it seems like a useful helper to move outside the `HttpTransport`.
When the profiler starts up, a number of other log messages are also printed, so let's get rid of a few. (Also, when it's disabled, it shows up on the environment logger, so that's already covered too.)
`EventGroup` has long since been removed from the codebase
github-actions
bot
added
core
AlexJF
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR pulls in a few small fixes that I originally included in #3384. See individual commits for details.
Motivation:
Since #3384 is still blocked on a few libdatadog changes/a libdatadog release, I decided to extract these fixes so we can have them already in master.
Additional Notes:
N/A
How to test the change?
These changes are covered by existing test coverage.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.