Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove custom transport proc instructions as they are no longer supported #3487

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

ekump
Copy link
Contributor

@ekump ekump commented Feb 26, 2024

2.0 Upgrade Guide notes
upgrade guide should already call out that custom transport procs are removed from 2.0

What does this PR do?
Update dev guide doc to remove instructions on how to implement a custom transport proc.

Motivation:
Support for custom transport procs has been removed in 2.0

Additional Notes:

How to test the change?
Doc change only

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@ekump ekump requested a review from a team as a code owner February 26, 2024 20:00
@github-actions github-actions bot added the docs Involves documentation label Feb 26, 2024
@pr-commenter
Copy link

pr-commenter bot commented Feb 26, 2024

Benchmarks

Benchmark execution time: 2024-02-26 20:19:56

Comparing candidate commit 936dcec in PR branch ekump/remove-transport-proc-info-from-dev-guide with baseline commit d24fd06 in branch 2.0.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 7 metrics, 1 unstable metrics.

@github-actions github-actions bot added core Involves Datadog core libraries and removed docs Involves documentation labels Feb 26, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (d24fd06) to head (936dcec).

Additional details and impacted files
@@            Coverage Diff             @@
##              2.0    #3487      +/-   ##
==========================================
- Coverage   98.07%   98.07%   -0.01%     
==========================================
  Files        1235     1235              
  Lines       71980    71980              
  Branches     3393     3393              
==========================================
- Hits        70595    70594       -1     
- Misses       1385     1386       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekump ekump merged commit f369330 into 2.0 Feb 27, 2024
154 checks passed
@ekump ekump deleted the ekump/remove-transport-proc-info-from-dev-guide branch February 27, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants