ekump/remove 2.4 safe dup string code #3457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
marcotc
approved these changes
Feb 13, 2024
ekump
force-pushed
the
ekump/remove-2.4-safe-dup-string-code
branch
from
3ad524f
to
00ee0a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.0 #3457 +/- ##
==========================================
+ Coverage 98.10% 98.12% +0.01%
==========================================
Files 1261 1260 -1
Lines 72985 72954 -31
Branches 3419 3405 -14
==========================================
- Hits 71605 71589 -16
+ Misses 1380 1365 -15 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0 Upgrade Guide notes
Should be covered by the upgrade notes on dropping support for ruby < 2.5
What does this PR do?
Removes some logic to backport methods present on certain types in Ruby 2.5+
Motivation:
We are not supporting Ruby < 2.5 in dd-trace-rb 2.0. We can simplify our codebase.
Additional Notes:
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!