-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROF-8917] Add support for the libdatadog crash tracker #3384
Merged
Merged
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
e1340de
Introduce setting to control crash tracker option
ivoanjo 789db6b
Extract `convert_tags` and `endpoint_from` from `HttpTransport` to li…
ivoanjo 8afc9f2
Extract `ddtrace_version` from `HttpTransport` to `ruby_helpers.h`
ivoanjo a9c51b0
[PROF-8917] Add support for the libdatadog crash tracker
ivoanjo d89e876
Add TODO about integration spec
ivoanjo d3bc290
Update `crash_tracker.c` with latest libdatadog API
ivoanjo 4889d05
Add experimental spec
ivoanjo 37f8082
Minor: Remove unused/outdated type declaration
ivoanjo 18758de
Redesign crash tracker to behave as regular object
ivoanjo 02d8691
Merge branch 'master' into ivoanjo/prof-8917-crash-tracker-ruby
ivoanjo bc7d72c
Wire new crash tracker design into profiler
ivoanjo 5312591
Minor: Remove redundant log message
ivoanjo 45f5daa
Avoid leaking threads and outputting errors during spec
ivoanjo a5c0ba2
Rename CrashTracker to Crashtracker to match libdatadog naming
ivoanjo fb45524
Match fixed case for crashtracker APIs
ivoanjo 6f83a4a
Merge branch 'master' into ivoanjo/prof-8917-crash-tracker-ruby
ivoanjo 6af57da
Update to libdatadog 7 APIs
ivoanjo d19ecde
Merge branch 'master' into ivoanjo/prof-8917-crash-tracker-ruby
ivoanjo e670699
Enable frame resolution
ivoanjo d37cbb8
Use in-receiver resolve frames
ivoanjo d8b4122
Merge branch 'master' into ivoanjo/prof-8917-crash-tracker-ruby
ivoanjo 6f3f8be
Adjust to latest libdatadog crash tracker changes
ivoanjo 66e8d95
Remove TODO, it's fixed now
ivoanjo ce15ade
Add detail to explaining why alt stack can't be used
ivoanjo 1b501cc
Clarify section of method where exceptions mustn't be raised
ivoanjo bd0537e
Document that crashtracker state is a singleton
ivoanjo 0b40fbf
Avoid hardcoding ports when testing with built-in webrick
ivoanjo a3081b4
Add test coverage for crashtracker surviving in `#component_failed`
ivoanjo 680c4a3
[NO-TICKET] Upgrade to libdatadog 8
ivoanjo 32f02b4
Update gemfiles with libdatadog 7 -> 8 upgrade
ivoanjo 356002e
Merge branch 'ivoanjo/libdatadog8-upgrade' into ivoanjo/prof-8917-cra…
ivoanjo 7776107
[NO-TICKET] Upgrade to libdatadog 9
AlexJF 520c8ab
Restore `required_ruby_version` to be in single line, but make Ruboco…
ivoanjo a6ddf72
Minor cleanups to comments
ivoanjo 3c27b38
Minor: Fix length of guide comment for breaking lines in message
ivoanjo ed971a5
Revert "[NO-TICKET] Upgrade to libdatadog 8"
ivoanjo f029683
Revert "Update gemfiles with libdatadog 7 -> 8 upgrade"
ivoanjo 7083455
Merge branch 'alexjf/libdatadog9' into ivoanjo/prof-8917-crash-tracke…
ivoanjo 49e9f31
Update Ruby crashtracker to libdatadog v9 API
ivoanjo 5197792
Setup `ld_library_path` argument for crashtracker
ivoanjo 7cda332
Use `profiling.upload.timeout_seconds` for crashtracker timeout
ivoanjo b87f171
Remove temporary libdatadog monkey patch
ivoanjo 3acf413
Fix `upload_timeout_seconds` being a float by default
ivoanjo bd7de08
Make rubocop happy
ivoanjo 09976cc
Minor: Add explanation for why we're skipping crash tracker with cust…
ivoanjo 5431d2b
Assert that no crashtracker is running before each test
ivoanjo a2ae730
Assert that correct signal name is reported
ivoanjo 42f6ca5
Minor: Empty commit to re-trigger CI
ivoanjo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add detail to explaining why alt stack can't be used
- Loading branch information
commit ce15ade38d4b3bedd4868c41abecfca0d0bde02c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, this is why this is an option here :)