Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure service and env are strings #3326

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Ensure service and env are strings #3326

merged 1 commit into from
Dec 14, 2023

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Dec 12, 2023

2.0 Upgrade Guide notes
The configuration settings c.env and c.service now have to be Strings.

Motivation:
There's no reason to be lenient for these two core configuration settings, they can only be meaningful text provided by the user.

Additional Notes:

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@marcotc marcotc requested a review from a team as a code owner December 12, 2023 23:19
@marcotc marcotc self-assigned this Dec 12, 2023
@github-actions github-actions bot added the core Involves Datadog core libraries label Dec 12, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7ef57c) 98.06% compared to head (23a9645) 98.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.0    #3326      +/-   ##
==========================================
- Coverage   98.06%   98.06%   -0.01%     
==========================================
  Files        1243     1243              
  Lines       71873    71865       -8     
  Branches     3388     3386       -2     
==========================================
- Hits        70481    70473       -8     
  Misses       1392     1392              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@marcotc marcotc merged commit 4dbbdb9 into 2.0 Dec 14, 2023
152 checks passed
@marcotc marcotc deleted the symbol-env branch December 14, 2023 21:07
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@ivoanjo ivoanjo added the 2.0 label Mar 14, 2024
@TonyCTHsu TonyCTHsu modified the milestones: 2.0, 2.0.0.beta1 Mar 22, 2024
@TonyCTHsu TonyCTHsu mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 core Involves Datadog core libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants