Remove deprecated B3 configuration style #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
force-pushed
the
remove-old-b3
branch
from
aca6574
to
cca755f
Compare
marcotc
force-pushed
the
remove-old-b3
branch
from
cca755f
to
ed7d516
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.0 #3294 +/- ##
=======================================
Coverage 97.99% 97.99%
=======================================
Files 1248 1248
Lines 72058 72031 -27
Branches 3401 3392 -9
=======================================
- Hits 70616 70590 -26
+ Misses 1442 1441 -1 ☔ View full report in Codecov by Sentry. |
ekump
approved these changes
Dec 5, 2023
This was referenced Apr 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0 Upgrade Guide notes
The deprecated
B3andB3 single headerpropagation style configuration values have been removed, useb3multiandb3respectively instead.What does this PR do?
Motivation:
The new values now align with OpenTelemetry propagation style names.
Additional Notes:
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!